Признак диагностики для разрешения размещения ее замечаний на уровне проекта #3223
Conversation
… могут быть размещены на уровне проекта
WalkthroughThe recent updates primarily introduce the ability to attach diagnostic remarks at the project level in SonarQube. This feature is useful for noting issues that apply to the configuration as a whole or when it's impossible to pinpoint a specific module or line. The changes include adding a new property to various diagnostic classes, updating documentation, and enhancing the Changes
Assessment against linked issues
PoemIn the realm of code where bugs do leap, Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- src/main/resources/com/github/_1c_syntax/bsl/languageserver/configuration/parameters-schema.json
- src/main/resources/com/github/_1c_syntax/bsl/languageserver/configuration/schema.json
Files selected for processing (12)
- docs/diagnostics/DenyIncompleteValues.md (1 hunks)
- docs/en/diagnostics/DeprecatedCurrentDate.md (1 hunks)
- docs/en/diagnostics/TransferringParametersBetweenClientAndServer.md (1 hunks)
- docs/en/diagnostics/UsingFindElementByString.md (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DenyIncompleteValuesDiagnostic.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ForbiddenMetadataNameDiagnostic.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/MetadataObjectNameLengthDiagnostic.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/SameMetadataObjectAndChildNamesDiagnostic.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ScheduledJobHandlerDiagnostic.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/metadata/DiagnosticInfo.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/metadata/DiagnosticMetadata.java (1 hunks)
- src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/metadata/DiagnosticInfoTest.java (6 hunks)
Files skipped from review due to trivial changes (3)
- docs/diagnostics/DenyIncompleteValues.md
- docs/en/diagnostics/UsingFindElementByString.md
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ScheduledJobHandlerDiagnostic.java
Additional comments: 12
docs/en/diagnostics/DeprecatedCurrentDate.md (1)
- 1-8: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [3-22]
The translation from English to Russian in the documentation is consistent with the provided summary and the examples are correctly formatted.
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DenyIncompleteValuesDiagnostic.java (1)
- 45-46: The addition of the
canLocateOnProjectproperty with a value oftrueto theDiagnosticMetadataannotation is consistent with the PR objectives and the AI-generated summary.src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/metadata/DiagnosticMetadata.java (1)
- 42-85: The expansion of the
DiagnosticMetadataannotation to include new fields such astype,severity,scope,modules,minutesToFix,activatedByDefault,compatibilityMode,tags, andcanLocateOnProjectis consistent with the PR objectives and the AI-generated summary.src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/MetadataObjectNameLengthDiagnostic.java (1)
- 45-46: The addition of the
canLocateOnProjectproperty with a value oftrueto theDiagnosticMetadataannotation is consistent with the PR objectives and the AI-generated summary.src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/SameMetadataObjectAndChildNamesDiagnostic.java (1)
- 57-58: The addition of the
canLocateOnProjectproperty with a value oftrueto theDiagnosticMetadataannotation is consistent with the PR objectives and the AI-generated summary.docs/en/diagnostics/TransferringParametersBetweenClientAndServer.md (2)
1-1: The title change to "Transferring parameters between the client and the server" is more grammatically correct.
3-4: The diagnostic description block has been translated, which aligns with the AI-generated summary.
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ForbiddenMetadataNameDiagnostic.java (1)
- 55-56: The addition of the
canLocateOnProjectproperty with a value oftrueto theDiagnosticMetadataannotation is consistent with the PR objectives and the AI-generated summary.src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/metadata/DiagnosticInfo.java (1)
- 197-199: The addition of the new public method
canLocateOnProjectto theDiagnosticInfoclass is consistent with the PR objectives and the AI-generated summary.src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/metadata/DiagnosticInfoTest.java (3)
28-28: The import for
ForbiddenMetadataNameDiagnosticis correctly added to support the new test case.65-89: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [54-70]
The test case for
EmptyCodeBlockDiagnostichas been updated with assertions for thecanLocateOnProjectproperty, which is set tofalse. This is consistent with the expected behavior for this diagnostic.
- 145-157: The new test case for
ForbiddenMetadataNameDiagnosticcorrectly asserts that thecanLocateOnProjectproperty istrue, which aligns with the changes made in the corresponding diagnostic class.
Qodana Community for JVM17 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
|
Описание
Связанные задачи
Closes #3222
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно
Summary by CodeRabbit
Documentation
New Features
Refactor